Hi Herbert, On Wed, Mar 13, 2024 at 09:45:15AM +0800, Herbert Xu wrote: > On Wed, Mar 13, 2024 at 09:43:52AM +0800, Herbert Xu wrote: > > > > Instead of using the non-existent crypto_comp_alg_common, it > > should do something like > > > > return crypto_acomp_tfm(tfm)->__crt_alg->cra_flags & ... > > Nevermind, the stats revert should not have removed acomp infrastructure > like this. > > I'll revert it. > > Thanks, The only user of comp_alg_common was the crypto stats, and it was introduced by a refactoring of the crypto stats (commit 0a742389bcc0, "crypto: acomp - Count error stats differently"), so it seems appropriate to remove it for now. If you could go through my patch and explain what other unused code related to the crypto stats you might consider to be "infrastructure" that should not be removed, that would be helpful. - Eric
