On 02/14, Tycho Andersen wrote: > > On Wed, Feb 14, 2024 at 06:55:55PM +0100, Oleg Nesterov wrote: > > > > We want to check the "flags" argument at the start, we do not want to > > delay the "case 0:" check until we have f.file (so that we can check > > f.file->f_flags). > > Fair point. I was thinking delaying it would make it simpler, but then > you have to free the file and it's less fast in the EINVAL case. plus we do not want to return, say, -EBADF if the "flags" argument is wrong. > I also don't have a strong opinion here. Neither me. Oleg.
