On Mon, 29 Jan 2024 at 02:22, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > In file included from include/linux/compiler_types.h:89, > from <command-line>: > kernel/irq/irq_sim.c: In function 'irq_domain_create_sim': > include/linux/compiler_attributes.h:76:41: error: expected expression before '__attribute__' > 76 | #define __cleanup(func) __attribute__((__cleanup__(func))) > | ^~~~~~~~~~~~~ > include/linux/cleanup.h:64:25: note: in expansion of macro '__cleanup' > 64 | #define __free(_name) __cleanup(__free_##_name) > | ^~~~~~~~~ > kernel/irq/irq_sim.c:173:19: note: in expansion of macro '__free' > 173 | pending = __free(bitmap) = bitmap_zalloc(num_irqs, GFP_KERNEL); > | ^~~~~~ > > Caused by commit > > 590610d72a79 ("genirq/irq_sim: Shrink code by using cleanup helpers") > > I have used the tip tree from next-20240125 for today. > > -- > Cheers, > Stephen Rothwell For the record: this is not my code. This is what I sent: https://lore.kernel.org/all/20240122124243.44002-5-brgl@xxxxxxxx/ Applying my version will fix the problem. Thanks, Bartosz