Hi Stephen,
On 01/25/24 at 02:29pm, Stephen Rothwell wrote:
......
> Caused by commit
>
> 9dc830523e4e ("ppc, crash: enforce KEXEC and KEXEC_FILE to select CRASH_DUMP")
>
> I have applied the following patch:
>
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Thu, 25 Jan 2024 14:20:51 +1100
> Subject: [PATCH] fix up for "ppc, crash: enforce KEXEC and KEXEC_FILE to
> select CRASH_DUMP"
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
> arch/powerpc/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 31f013e636e3..e7707bebc061 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -610,6 +610,8 @@ config ARCH_SUPPORTS_KEXEC
>
> config ARCH_SELECTS_KEXEC
> def_bool y
> + depends on ARCH_SUPPORTS_CRASH_DUMP
> + depends on KEXEC_CORE
> select CRASH_DUMP
>
> config ARCH_SUPPORTS_KEXEC_FILE
Thanks for the work.
I reproduced the failure with allnoconfig on ppc, and found below change
can fix it too. And the change makes ARCH_SELECTS_KEXEC consistent with
ARCH_SELECTS_KEXEC_FILE on the dependency. What do you think?
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 31f013e636e3..79f98cd5f2c9 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -610,6 +610,7 @@ config ARCH_SUPPORTS_KEXEC
config ARCH_SELECTS_KEXEC
def_bool y
+ depends on KEXEC
select CRASH_DUMP
config ARCH_SUPPORTS_KEXEC_FILE
