Hi Baoquan, On Fri, Dec 8, 2023 at 8:43 AM Baoquan He <bhe@xxxxxxxxxx> wrote: > Forgot adding kexec to CC, add it now. > > On 12/08/23 at 03:30pm, Baoquan He wrote: > > The select of KEXEC for CRASH_DUMP in kernel/Kconfig.kexec will be > > dropped, then compiling errors will be triggered if below config > > items are set: > > > > === > > CONFIG_CRASH_CORE=y > > CONFIG_KEXEC_CORE=y > > CONFIG_CRASH_DUMP=y > > === > > > > E.g on mips, below link error are seen: > > -------------------------------------------------------------------- > > mipsel-linux-ld: kernel/kexec_core.o: in function `kimage_free': > > kernel/kexec_core.c:(.text+0x2200): undefined reference to `machine_kexec_cleanup' > > mipsel-linux-ld: kernel/kexec_core.o: in function `__crash_kexec': > > kernel/kexec_core.c:(.text+0x2480): undefined reference to `machine_crash_shutdown' > > mipsel-linux-ld: kernel/kexec_core.c:(.text+0x2488): undefined reference to `machine_kexec' > > mipsel-linux-ld: kernel/kexec_core.o: in function `kernel_kexec': > > kernel/kexec_core.c:(.text+0x29b8): undefined reference to `machine_shutdown' > > mipsel-linux-ld: kernel/kexec_core.c:(.text+0x29c0): undefined reference to `machine_kexec' > > -------------------------------------------------------------------- > > > > Here, change the incorrect dependency of building kexec_core related object > > files, and the ifdeffery on architectures from CONFIG_KEXEC to > > CONFIG_KEXEC_CORE. > > > > Testing: > > ======== > > Passed on mips and loognarch with the LKP reproducer. > > > > Baoquan He (5): > > loongarch, kexec: change dependency of object files > > m68k, kexec: fix the incorrect ifdeffery and build dependency of > > CONFIG_KEXEC > > mips, kexec: fix the incorrect ifdeffery and dependency of > > CONFIG_KEXEC > > sh, kexec: fix the incorrect ifdeffery and dependency of CONFIG_KEXEC > > x86, kexec: fix the wrong ifdeffery CONFIG_KEXEC I understand this series is v3 of "[PATCH v2] kexec_core: change dependency of object files"? As this series does not contain a changelog, can you please summarize what was changed? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds