Em Wed, Dec 06, 2023 at 09:14:33AM +1100, Stephen Rothwell escreveu:
> Commit
> 08b953508560 ("perf evsel: Fallback to "task-clock" when not system wide")
> is missing a Signed-off-by from its author.
Thanks for the report, fixed, the issue was that Ian's S-o-B was after a
--- line and thus git-am chopped it up :-\
===============================================================================
When the cycles event isn't available evsel will fallback to the
cpu-clock software event. task-clock is similar to cpu-clock but only
runs when the process is running. Falling back to cpu-clock when not
system wide leads to confusion, by falling back to task-clock it is
hoped the confusion is less.
Pass the target to determine if task-clock is more appropriate. Update
a nearby comment and debug string for the change.
---
v2. Use target__has_cpu as suggested by Namhyung.
https://lpc.events/event/17/contributions/1556/
Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
tools/perf/builtin-record.c | 2 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/util/evsel.c | 18 ++++++++++--------
tools/perf/util/evsel.h | 3 ++-
5 files changed, 15 insertions(+), 12 deletions(-
--
===============================================================================
I'll check my pre-commit hooks to see why this didn't get flagged...
- Arnaldo
