On Mon, 30 Oct 2023 21:51:57 -0700 Eric Biggers wrote:
> On Mon, Oct 30, 2023 at 03:02:43PM -0700, Jakub Kicinski wrote:
> > On Mon, 30 Oct 2023 13:23:53 +0800 Herbert Xu wrote:
> > > If we simply apply this patch to the netdev tree then everything
> > > should work at the next merge window. But perhaps you could change
> > > the patch description to say something like remove the obsolete
> > > crypto_hash_alignmask. It's not important though.
> >
> > I'm happy to massage the commit message and apply the fix to net.
> > But is it actually 100% correct to do that? IOW is calling
> > crypto_ahash_alignmask() already not necessary in net-next or does
> > it only become unnecessary after some prep work in crypto-next?
> >
> > We can tell Linus to squash this fix into the merge of either
> > crypto-next or net-next, I'm pretty sure he'd be okay with that..
>
> It's safe to fold the patch into net-next. It actually looks like a bug to be
> using the alignmask in the way that net/ipv4/tcp_ao.c is using it. You don't
> want to be erroring out just because the algorithm declared an alignmask.
Thanks Eric! Applied as commit f2fbb9081123 ("net: tcp: remove call to
obsolete crypto_ahash_alignmask()") to net-next. I'll respin our PR
after some sanity checking.
