> -----Original Message----- > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Sent: Monday, 28 August 2023 23:36 > To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>; Linux Next Mailing List <linux- > next@xxxxxxxxxxxxxxx> > Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; open list:X86 > PLATFORM DRIVERS <platform-driver-x86@xxxxxxxxxxxxxxx>; Vadim Pasternak > <vadimp@xxxxxxxxxx>; Hans de Goede <hdegoede@xxxxxxxxxx>; Mark > Gross <markgross@xxxxxxxxxx>; PCI <linux-pci@xxxxxxxxxxxxxxx> > Subject: Re: linux-next: Tree for Aug 28 (drivers/platform/x86/mlx-platform.c) > > > > On 8/27/23 22:02, Stephen Rothwell wrote: > > Hi all, > > > > Please do *not* include material destined for v6.7 in your linux-next > > included branches until *after* v6.6-rc1 has been released. Also, do > > *not* rebase you linu-next included branches onto v6.5. > > > > Changes since 20230825: > > > > on i386: > CONFIG_ACPI=y > CONFIG_ISA=y > # CONFIG_PCI is not set > > ../drivers/platform/x86/mlx-platform.c: In function > 'mlxplat_pci_fpga_device_init': > ../drivers/platform/x86/mlx-platform.c:6204:15: error: implicit declaration of > function 'pci_request_region'; did you mean 'pci_request_regions'? [- > Werror=implicit-function-declaration] > 6204 | err = pci_request_region(pci_dev, 0, res_name); > | ^~~~~~~~~~~~~~~~~~ > | pci_request_regions > > Should MLX_PLATFORM depend on PCI? > > or do we need a stub for pci_request_region()? Thanks, Randy. Need to add: 'depend on PCI'. I will send a patch. > > -- > ~Randy
