On Thu, 20 Jul 2023 11:00:21 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi all, > > On Wed, 19 Jul 2023 19:47:42 -0500 Steve French <smfrench@xxxxxxxxx> > wrote: > > > > Winston had an updated version of the patch - just replaced it with > > his updated one which does a cast to (char *) > > > > ses->local_nls = load_nls((char > > *)ctx->local_nls->charset); > > > > But as he noted in an earlier email thread: > > > Perhaps I should make a change to load_nls() to take a const char > > > * instead of char *? If this make sense, I'll do it soon. > > > > which is probably cleaner > > s/probably/definitely/ ;-) > haha yes! I'll make a small patch for this in the next cycle. -- Thanks, Winston