On Mon, Jul 10, 2023 at 9:21 AM Aurabindo Pillai
<aurabindo.pillai@xxxxxxx> wrote:
>
>
>
> On 7/9/2023 6:25 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > aeddb7d13ad3 ("drm/amd/display: Block optimize on consecutive FAMS enables")
> >
> > is missing a Signed-off-by from its author.
> >
>
> Hi Stephen,
>
> Not sure how the tags went missing, but here is the full commit
> (a7d8d8bcbd9af8d4aa1580bffd418af78384040f) information from
> amd-staging-drm-next:
>
>
> drm/amd/display: Block optimize on consecutive FAMS enables
>
> [WHY]
> It is possible to commit state multiple times in rapid succession with
> FAMS enabled; if each of these commits were to set optimized_required,
> then the user may see latency.
>
> [HOW]
> fw_based_mclk_switching is currently not used in dc->clk_mgr; use it
> to track whether the current state has FAMS enabled;
> if it has, then do not disable FAMS in prepare_bandwidth, and do
> not set
> optimized_required.
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
> Signed-off-by: Wesley Chalmers <Wesley.Chalmers@xxxxxxx>
> Tested-by: Daniel Wheeler <daniel.wheeler@xxxxxxx>
> Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> Acked-by: Hamza Mahfooz <hamza.mahfooz@xxxxxxx>
>
I've fixed it up in my tree.
Alex
