Hi Simon,
On 7/6/23 14:45, Simon Horman wrote:
> + Pavithra Sathyanarayanan
>
> On Tue, Jul 04, 2023 at 03:25:31AM -0700, Randy Dunlap wrote:
>>
>>
>> On 7/3/23 20:43, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Please do *not* add any v6.6 related stuff to your linux-next included
>>> branches until after v6.5-rc1 has been released.
>>>
>>> Changes since 20230703:
>>>
>>
>> on s390:
>>
>> s390-linux-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_phy_open':
>> drivers/net/ethernet/microchip/lan743x_main.c:1514: undefined reference to `fixed_phy_register'
>>
>>
>> Full randconfig file is attached.
>
> Thanks for the config.
>
> I bisected this problem and it appears to be introduced by:
>
> 624864fbff92 ("net: lan743x: add fixed phy support for LAN7431 device")
>
> I wonder if the following change in dependencies is an appropriate fix for
> this problem.
Yes, that change fixes the build error. Thanks.
Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
>
> diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig
> index 24c994baad13..329e374b9539 100644
> --- a/drivers/net/ethernet/microchip/Kconfig
> +++ b/drivers/net/ethernet/microchip/Kconfig
> @@ -46,7 +46,7 @@ config LAN743X
> tristate "LAN743x support"
> depends on PCI
> depends on PTP_1588_CLOCK_OPTIONAL
> - select PHYLIB
> + select FIXED_PHY
> select CRC16
> select CRC32
> help
>
--
~Randy
