On Fri, Jun 23, 2023 at 10:34 AM Alexander Mikhalitsyn <alexander@xxxxxxxxxxxxx> wrote: > > On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz > <luiz.von.dentz@xxxxxxxxx> wrote: > > > > Hi Stephen, Alexander, > > Dear friends, > > > > > Looks like we have a similar problem as to: > > > > https://lore.kernel.org/lkml/20230524081933.44dc8bea@xxxxxxxxxx/ > > > > That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw). > > Ugh, yep. That's bad and we can't workaround it like we did for unix sockets. > > Originally, Christian had objections against exporting the > pidfd_prepare function [1] > > [1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/ > > +cc Christian Idea. (-: We can introduce a new function like "scm_recv_light" that will be just an old version of "scm_recv" without using pidfd, if this feature with SCM_PIDFD is not important for hci sockets. Forgot to add Jakub to CC. +cc Jakub > > Kind regards, > Alex > > > > > > > ________________________________ From: Stephen Rothwell > > Sent: Monday, June 12, 2023 8:02 PM > > To: Marcel Holtmann; Johan Hedberg > > Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List > > Subject: linux-next: build failure after merge of the bluetooth tree > > > > Hi all, > > > > After merging the bluetooth tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined! > > > > Caused by commit > > > > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor") > > > > I have reverted that commit for today. > > > > -- > > Cheers, > > Stephen Rothwell
