On 6/18/23 15:22, Stephen Rothwell wrote:
> Hi all,
>
> [Also in the device-mapper tree]
>
> In commit
>
> 900095bfbbf6 ("nvme-fabrics: error out to unlock the mutex")
>
> Fixes tag
>
> Fixes: f0cebf82004d ("nvme-fabrics: prevent overriding of existing host")
sorry I didn't understand this with above tag I could format a patch
that leads to above subject line :-
nvme (nvme-6.5) # git format-patch f0cebf82004d -1
0001-nvme-fabrics-prevent-overriding-of-existing-host.patch
directory
nvme (nvme-6.5) # cat
0001-nvme-fabrics-prevent-overriding-of-existing-host.patch
From f0cebf82004d610be3ef47abf315ddf95aa2dcd1 Mon Sep 17 00:00:00 2001
From: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
Date: Fri, 12 May 2023 18:41:55 +0300
Subject: [PATCH] nvme-fabrics: prevent overriding of existing host
When first connecting a target using the "default" host parameters,
setting the hostid from the command line during a subsequent connection
establishment would override the "default" hostid parameter. This would
cause an existing connection that is already using the host definitions
to lose its hostid.
To address this issue, the code has been modified to allow only 1:1
mapping between hostnqn and hostid. This will maintain unambiguous host
identification. Any non 1:1 mapping will be rejected during connection
establishment.
Tested-by: Noam Gottlieb <ngottlieb@xxxxxxxxxx>
Reviewed-by: Israel Rukshin <israelr@xxxxxxxxxx>
Signed-off-by: Max Gurtovoy <mgurtovoy@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Keith Busch <kbusch@xxxxxxxxxx>
---
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: ae8bd606e09b ("nvme-fabrics: prevent overriding of existing host")
>
