On 23/5/2023 2:56 pm, Conor Dooley wrote: > On Tue, May 23, 2023 at 10:33:38AM +0800, Herbert Xu wrote: >> On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote: >> > >> > That did not fix it :-( >> >> OK, this patch should fix it: >> >> ---8<--- >> A platform option like AMBA should never be selected by a driver. >> Use a dependency instead. > > Randy submitted a patch to change the driver to not conflict with > the arch symbols: > https://lore.kernel.org/all/20230523000606.9405-1-rdunlap@xxxxxxxxxxxxx/ > > The corresponding change here makes sense to me, > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > @StarFive folks, you will need to go and submit a patch for > arch/riscv/Kconfig.socs that selects ARM_AMBA for your platform. > Sure, I'll submit a patch for this. Thanks Jia Jie