Hi Mita-san, On Mon, Mar 27, 2023 at 4:48 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > This provides a helper function to allow configuration of fault-injection > for configfs-based drivers. > > The config items created by this function have the same interface as the > one created under debugfs by fault_create_debugfs_attr(). > > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> Thanks for your patch, which is now commit 4668c7a2940d134b ("fault-inject: allow configuration via configfs") in linux-next (to be tagged soon as next-20140414). > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1977,9 +1977,20 @@ config FAIL_SUNRPC > Provide fault-injection capability for SunRPC and > its consumers. > > +config FAULT_INJECTION_CONFIGFS > + bool "Configfs interface for fault-injection capabilities" > + depends on FAULT_INJECTION && CONFIGFS_FS noreply@xxxxxxxxxxxxxx reported build failures for e.g. m68k-allmodconfig http://kisskb.ellerman.id.au/kisskb/buildresult/14911188/: fault-inject.c:(.text+0x1ee): undefined reference to `config_group_init_type_name' This fails because FAULT_INJECTION=y but CONFIGFS_FS=m. > + help > + This option allows configfs-based drivers to dynamically configure > + fault-injection via configfs. Each parameter for driver-specific > + fault-injection can be made visible as a configfs attribute in a > + configfs group. > + > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds