On 06.03.2023 22:37, Stephen Rothwell wrote: > Hi all, > > Commit > > 58aac3a2ef41 ("net: phy: smsc: fix link up detection in forced irq mode") > > is missing a Signed-off-by from its committer. > Seems to be ok, false positive? net: phy: smsc: fix link up detection in forced irq mode Currently link up can't be detected in forced mode if polling isn't used. Only link up interrupt source we have is aneg complete which isn't applicable in forced mode. Therefore we have to use energy-on as link up indicator. Fixes: 7365494550f6 ("net: phy: smsc: skip ENERGYON interrupt if disabled") Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>