On Tue, Dec 20, 2022 at 08:37:09AM +0100, Ricardo Cañuelo wrote: > Fixes two warning messages when building htmldocs: > > warning: duplicate section name 'Note' > warning: expecting prototype for virtio_config_ops(). > Prototype was for vq_callback_t() instead > Describe the steps needed to fix both warnings above. I see in the diff that: * move vq_callback_t() declaration above; * match entity type of virtio_config_ops; and * reformat @finalize_features description. > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@xxxxxxxxxxxxx> You need to add appropriate tags: Link: https://lore.kernel.org/linux-next/20221220105956.4786852d@xxxxxxxxxxxxxxxx/ Fixes: 333723e8bc393d ("docs: driver-api: virtio: virtio on Linux") Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > --- > include/linux/virtio_config.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > index 4b517649cfe8..f9a33062c089 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virtio_config.h > @@ -16,8 +16,10 @@ struct virtio_shm_region { > u64 len; > }; > > +typedef void vq_callback_t(struct virtqueue *); > + > /** > - * virtio_config_ops - operations for configuring a virtio device > + * struct virtio_config_ops - operations for configuring a virtio device > * Note: Do not assume that a transport implements all of the operations > * getting/setting a value as a simple read/write! Generally speaking, > * any of @get/@set, @get_status/@set_status, or @get_features/ > @@ -68,8 +70,8 @@ struct virtio_shm_region { > * @finalize_features: confirm what device features we'll be using. > * vdev: the virtio_device > * This sends the driver feature bits to the device: it can change > - * the dev->feature bits if it wants. > - * Note: despite the name this can be called any number of times. > + * the dev->feature bits if it wants. Note: despite the name this > + * can be called any number of times. > * Returns 0 on success or error status > * @bus_name: return the bus name associated with the device (optional) > * vdev: the virtio_device > @@ -91,7 +93,6 @@ struct virtio_shm_region { > * If disable_vq_and_reset is set, then enable_vq_after_reset must also be > * set. > */ > -typedef void vq_callback_t(struct virtqueue *); > struct virtio_config_ops { > void (*get)(struct virtio_device *vdev, unsigned offset, > void *buf, unsigned len); Anyway, the warnings went away, thanks for the fixup! Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx> -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
