On Tue, 13 Dec 2022 11:42:49 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > Hi Steven, > > On Mon, 12 Dec 2022 17:56:42 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > Bah, not sure how this happened. I thought I pulled these patches directly > > from Masami. Does a rebase change the committer tags? As I probably rebased > > them on top of my branch. > > From "git help rebase" > > --signoff > Add a Signed-off-by trailer to all the rebased commits. Note that > if --interactive is given then only commits marked to be picked, > edited or reworded will have the trailer added. > > So this is not done by default. Yet another reason to avoid rebasing > others work unless absolutely necessary. > Yeah, this is temporary, as Masami is still setting up his test environment, he just asked me to pull his changes on top of mine so that I can run them. Now I know what not to do ;-) -- Steve
