Hi Hans,
On Wed, 7 Dec 2022 11:08:37 +0100 Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote:
>
> On 12/6/22 21:56, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commits
> >
> > 85abf40b56af ("media: ipu3-cio2: make the bridge depend on i2c")
> > ca61babacbe8 ("media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer")
> >
> > are missing a Signed-off-by from their committer.
> >
>
> They have a SoB, but there is a 'Link:' tag right before that:
>
> commit 85abf40b56af5f3130a4f9dcdb808c7feb64e083
> Author: Adam Borowski <kilobyte@xxxxxxxxxx>
> Date: Fri Sep 16 00:33:18 2022 +0100
>
> media: ipu3-cio2: make the bridge depend on i2c
>
> drivers/media/pci/intel/ipu3/cio2-bridge.c: In function ‘cio2_bridge_unregister_sensors’:
> drivers/media/pci/intel/ipu3/cio2-bridge.c:258:17: error: implicit declaration of function ‘i2c_unregister_device’; did you mean ‘spi_unregister_device’? [-Werror=implicit-function-declaration]
> 258 | i2c_unregister_device(sensor->vcm_i2c_client);
> | ^~~~~~~~~~~~~~~~~~~~~
> | spi_unregister_device
>
> Link: https://lore.kernel.org/linux-media/S230142AbiJTWql/20221020224641Z+958@xxxxxxxxxxxxxxx
> Signed-off-by: Adam Borowski <kilobyte@xxxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
> commit ca61babacbe8ada7a0671f910c22b8758f481c0c
> Author: Hans de Goede <hdegoede@xxxxxxxxxx>
> Date: Wed Nov 23 16:14:47 2022 +0000
>
> media: MAINTAINERS: Add Hans de Goede as staging/atomisp maintainer
>
> Add myself as maintainer for the drivers/staging/media/atomisp code.
>
> Link: https://lore.kernel.org/linux-media/20221123161447.15834-1-hdegoede@xxxxxxxxxx
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
> Could that be the cause? checkpatch doesn't complain about this.
They have no SOB line from you and you are the one who committed them.
--
Cheers,
Stephen Rothwell
Attachment:
pgp8jkl83z0Py.pgp
Description: OpenPGP digital signature
