Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221110 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Thu Oct 27 14:37:38 2022 +0300 153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor") Coverity reported the following: *** CID 1527248: Control flow issues (NO_EFFECT) drivers/media/i2c/st-vgxy61.c:1651 in vgxy61_detect_cut_version() 1645 static int vgxy61_detect_cut_version(struct vgxy61_dev *sensor) 1646 { 1647 struct i2c_client *client = sensor->i2c_client; 1648 u16 device_rev; 1649 1650 device_rev = vgxy61_read_reg(sensor, VGXY61_REG_REVISION); vvv CID 1527248: Control flow issues (NO_EFFECT) vvv This less-than-zero comparison of an unsigned value is never true. "device_rev < 0". 1651 if (device_rev < 0) 1652 return device_rev; 1653 1654 switch (device_rev >> 8) { 1655 case 0xA: 1656 dev_dbg(&client->dev, "Cut1 detected\n"); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1527248 ("Control flow issues") Fixes: 153e4ad44d60 ("media: i2c: Add driver for ST VGXY61 camera sensor") Thanks for your attention! -- Coverity-bot
