Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221110 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Thu Oct 27 14:48:40 2022 +0300 80a21da36051 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver") Coverity reported the following: *** CID 1527252: Control flow issues (DEADCODE) drivers/media/i2c/tc358746.c:411 in tc358746_apply_pll_config() 405 return err; 406 407 val = PLL_FRS(ilog2(post)) | RESETB | PLL_EN; 408 mask = PLL_FRS_MASK | RESETB | PLL_EN; 409 tc358746_update_bits(tc358746, PLLCTL1_REG, mask, val); 410 if (err) vvv CID 1527252: Control flow issues (DEADCODE) vvv Execution cannot reach this statement: "return err;". 411 return err; 412 413 fsleep(1000); 414 415 return tc358746_set_bits(tc358746, PLLCTL1_REG, CKEN); 416 } If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1527252 ("Control flow issues") Fixes: 80a21da36051 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver") Thanks for your attention! -- Coverity-bot
