Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221104 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Wed Nov 2 12:31:23 2022 +0000 049fe5365324 ("net: txgbe: Add operations to interact with firmware") Coverity reported the following: *** CID 1527152: Control flow issues (NO_EFFECT) drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c:200 in txgbe_calc_eeprom_checksum() 194 195 for (i = 0; i < TXGBE_EEPROM_LAST_WORD; i++) 196 if (i != wxhw->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM) 197 *checksum += local_buffer[i]; 198 199 *checksum = TXGBE_EEPROM_SUM - *checksum; vvv CID 1527152: Control flow issues (NO_EFFECT) vvv This less-than-zero comparison of an unsigned value is never true. "*checksum < 0". 200 if (*checksum < 0) 201 return -EINVAL; 202 203 if (eeprom_ptrs) 204 kvfree(eeprom_ptrs); 205 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1527152 ("Control flow issues") Fixes: 049fe5365324 ("net: txgbe: Add operations to interact with firmware") Thanks for your attention! -- Coverity-bot
