Re: linux-next: Signed-off-by missing for commit in the xfs tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dave Chinner <david@xxxxxxxxxxxxx> 于2022年10月5日周三 05:06写道:
> As it is, I use the convention of putting an explicit From: tag in
> the commit message that matches the SOB so tools pulling stuff from
> mailing lists do the right thing with them (same as any third-party
> provided patch in a series).
>
> > That said... I think we should get in the habit of asking patch authors
> > to make sure that at least one of the email or name strings match
> > between the From and SOB tags.  I can see how people who grok even less
> > about how Chinese names work than I do (read: lawyers) might get fussy
> > about this kind of thing.
>
> As per above, the normal solution is an explicit "From: <foo>" line
> that matches the SOB.  It's just annoying that our new-fangled tools
> haven't encoded this long-standing convention to warn us when we
> pull a patch with a from-tag that doesn't match a sob-tag.
>

Sorry, but I'm not sure whether what you mean is adding another "From: " line
right above the SOB tag like:
====
From: name2 <email address2>
Date: Mon, 12 Sep 2022 xx:xx:xx +0800
Subject: [PATCH ] xfs: fix xxx and xxx

...
the commit  message
...

From: name <email address>             //added line
signed-off-by:  name <email address>
...
====

Thanks,
Stephen.




[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux