On Fri 26-08-22 17:10:20, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mm tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> arch/powerpc/xmon/xmon.c: In function 'cmds':
> arch/powerpc/xmon/xmon.c:1089:33: error: too few arguments to function 'show_mem'
> 1089 | show_mem(0, NULL);
> | ^~~~~~~~
> In file included from arch/powerpc/xmon/xmon.c:14:
> include/linux/mm.h:2585:13: note: declared here
> 2585 | extern void show_mem(unsigned int flags, nodemask_t *nodemask, gfp_t gfp_mask);
> | ^~~~~~~~
>
> Caused by commit
>
> 9ea9abc5cd7e ("mm: reduce noise in show_mem for lowmem allocations")
>
> I have reverted that commit for today (and the following fix).
This should fix it. Andrew, could you fold it into the patch please?
git grep doesn't suggest more instances AFAICS
---
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 3d9782ea3fa7..19b1a94b0c00 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1086,7 +1086,7 @@ cmds(struct pt_regs *excp)
memzcan();
break;
case 'i':
- show_mem(0, NULL);
+ show_mem(0, NULL, GFP_HIGHUSER_MOVABLE);
break;
default:
termch = cmd;
--
Michal Hocko
SUSE Labs
