On 7/14/22 10:10 PM, Al Viro wrote:
> On Fri, Jul 15, 2022 at 02:02:59PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/block/ublk_drv.c:951:19: error: 'no_llseek' undeclared here (not in a function); did you mean 'noop_llseek'?
>> 951 | .llseek = no_llseek,
>> | ^~~~~~~~~
>> | noop_llseek
>>
>> Caused by commit
>>
>> 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
>>
>> interacting with commit
>>
>> 8804bffa93a1 ("fs: remove no_llseek")
>>
>> from the vfs tree.
>
> I suspect that it would be a good idea to slap
> #define no_llseek NULL
> into include/linux/fs.h for the merge window, then remove it (and all
> stray no_llseek initializers) at -rc1. Linus, would you be OK with
> that approach?
Not Linus, but I think that's a good idea as it'll reduce the pain for
any new users added in other trees.
--
Jens Axboe
