Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/net/sock.h between commit: 310731e2f161 ("net: Fix data-races around sysctl_mem.") from the net tree and commit: e70f3c701276 ("Revert "net: set SK_MEM_QUANTUM to 4096"") from the net-next tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc include/net/sock.h index 9fa54762e077,0dd43c3df49b..000000000000 --- a/include/net/sock.h +++ b/include/net/sock.h @@@ -1521,22 -1541,10 +1541,10 @@@ void __sk_mem_reclaim(struct sock *sk, #define SK_MEM_SEND 0 #define SK_MEM_RECV 1 - /* sysctl_mem values are in pages, we convert them in SK_MEM_QUANTUM units */ + /* sysctl_mem values are in pages */ static inline long sk_prot_mem_limits(const struct sock *sk, int index) { - long val = READ_ONCE(sk->sk_prot->sysctl_mem[index]); - - #if PAGE_SIZE > SK_MEM_QUANTUM - val <<= PAGE_SHIFT - SK_MEM_QUANTUM_SHIFT; - #elif PAGE_SIZE < SK_MEM_QUANTUM - val >>= SK_MEM_QUANTUM_SHIFT - PAGE_SHIFT; - #endif - return val; - return sk->sk_prot->sysctl_mem[index]; ++ return READ_ONCE(sk->sk_prot->sysctl_mem[index]); } static inline int sk_mem_pages(int amt)
Attachment:
pgpbJV9I37HQ4.pgp
Description: OpenPGP digital signature