On 6/20/22 09:34, Stephen Rothwell wrote: > Hi all, > > After merging the libata tree, today's linux-next build (powercp > ppc64_defconfig) produced this warning: Will fix that. > > In file included from include/linux/device.h:15, > from arch/powerpc/include/asm/io.h:27, > from include/linux/io.h:13, > from include/linux/irq.h:20, > from arch/powerpc/include/asm/hardirq.h:6, > from include/linux/hardirq.h:11, > from include/linux/highmem.h:11, > from include/linux/bvec.h:10, > from include/linux/blk_types.h:10, > from include/linux/blkdev.h:9, > from drivers/ata/pata_macio.c:18: > drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks': > drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=] > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk' > 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > | ^~~ > include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt' > 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > | ^~~~~~~ > drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg' > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ^~~~~~~ > drivers/ata/pata_macio.c:1031:52: note: format string is defined here > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ~~^ > | | > | long unsigned int > | %x > In file included from include/linux/device.h:15, > from arch/powerpc/include/asm/io.h:27, > from include/linux/io.h:13, > from include/linux/irq.h:20, > from arch/powerpc/include/asm/hardirq.h:6, > from include/linux/hardirq.h:11, > from include/linux/highmem.h:11, > from include/linux/bvec.h:10, > from include/linux/blk_types.h:10, > from include/linux/blkdev.h:9, > from drivers/ata/pata_macio.c:18: > drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=] > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk' > 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > | ^~~ > include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt' > 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > | ^~~~~~~ > drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg' > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ^~~~~~~ > drivers/ata/pata_macio.c:1031:63: note: format string is defined here > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ~~^ > | | > | long unsigned int > | %x > In file included from include/linux/device.h:15, > from arch/powerpc/include/asm/io.h:27, > from include/linux/io.h:13, > from include/linux/irq.h:20, > from arch/powerpc/include/asm/hardirq.h:6, > from include/linux/hardirq.h:11, > from include/linux/highmem.h:11, > from include/linux/bvec.h:10, > from include/linux/blk_types.h:10, > from include/linux/blkdev.h:9, > from drivers/ata/pata_macio.c:18: > drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=] > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk' > 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > | ^~~ > include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt' > 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > | ^~~~~~~ > drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg' > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ^~~~~~~ > drivers/ata/pata_macio.c:1031:73: note: format string is defined here > 1031 | dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n", > | ~~^ > | | > | long unsigned int > | %x > > Introduced by commit > > f0a6d77b351c ("ata: make transfer mode masks *unsigned int*") > -- Damien Le Moal Western Digital Research