Hi all, On Tue, 2022-04-26 at 18:30 +1000, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o:(.opd+0x18): multiple definition of > `adsp_clock_on'; sound/soc/sof/mediatek/mt8195/mt8195-clk.o:(.opd+0x60): first defined here > ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o: in function `.adsp_clock_on': > mt8186-clk.c:(.text.adsp_clock_on+0x0): multiple definition of `.adsp_clock_on'; > sound/soc/sof/mediatek/mt8195/mt8195-clk.o:mt8195-clk.c:(.text.adsp_clock_on+0x0): first defined > here > ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o:(.opd+0x30): multiple definition of > `adsp_clock_off'; sound/soc/sof/mediatek/mt8195/mt8195-clk.o:(.opd+0x78): first defined here > ld: sound/soc/sof/mediatek/mt8186/mt8186-clk.o: in function `.adsp_clock_off': > mt8186-clk.c:(.text.adsp_clock_off+0x0): multiple definition of `.adsp_clock_off'; > sound/soc/sof/mediatek/mt8195/mt8195-clk.o:mt8195-clk.c:(.text.adsp_clock_off+0x0): first defined > here > ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o:(.opd+0x0): multiple definition of > `sof_hifixdsp_boot_sequence'; sound/soc/sof/mediatek/mt8195/mt8195-loader.o:(.opd+0x0): first > defined here > ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o: in function `.sof_hifixdsp_boot_sequence': > mt8186-loader.c:(.text.sof_hifixdsp_boot_sequence+0x0): multiple definition of > `.sof_hifixdsp_boot_sequence'; sound/soc/sof/mediatek/mt8195/mt8195-loader.o:mt8195- > loader.c:(.text.sof_hifixdsp_boot_sequence+0x0): first defined here > ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o:(.opd+0x18): multiple definition of > `sof_hifixdsp_shutdown'; sound/soc/sof/mediatek/mt8195/mt8195-loader.o:(.opd+0x18): first defined > here > ld: sound/soc/sof/mediatek/mt8186/mt8186-loader.o: in function `.sof_hifixdsp_shutdown': > mt8186-loader.c:(.text.sof_hifixdsp_shutdown+0x0): multiple definition of > `.sof_hifixdsp_shutdown'; sound/soc/sof/mediatek/mt8195/mt8195-loader.o:mt8195- > loader.c:(.text.sof_hifixdsp_shutdown+0x0): first defined here > > Caused by commits > > 570c14dc92d5 ("ASoC: SOF: mediatek: Add mt8186 sof fw loader and dsp ops") > 210b3ab932f7 ("ASoC: SOF: mediatek: Add mt8186 dsp clock support") > > I have reverted those commits and the following > > 0e0b83cc7ec7 ("ASoC: SOF: mediatek: Add DSP system PM callback for mt8186") > > for today. I'm apologies for your inconvenience. I've pushed a quick fix at https://lore.kernel.org/alsa-devel/20220427034425.24294-1-tinghan.shen@xxxxxxxxxxxx/T/#u Thanks & Regards TingHan >