Hi all, Today's linux-next merge of the device-mapper tree got a conflict in: drivers/md/dm.c between commit: a773187e37fa ("scsi: dm: Remove WRITE_SAME support") from Linus' tree and commit: 259a97ec4818 ("dm: optimize is_abnormal_io for normal rw IO") from the device-mapper tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/md/dm.c index ad2e0bbeb559,853185992c5c..000000000000 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@@ -1413,17 -1504,21 +1493,20 @@@ static void __send_changing_extent_only static bool is_abnormal_io(struct bio *bio) { - bool r = false; + unsigned int op = bio_op(bio); - switch (bio_op(bio)) { - case REQ_OP_DISCARD: - case REQ_OP_SECURE_ERASE: - case REQ_OP_WRITE_ZEROES: - r = true; - break; + if (op != REQ_OP_READ && op != REQ_OP_WRITE && op != REQ_OP_FLUSH) { + switch (op) { + case REQ_OP_DISCARD: + case REQ_OP_SECURE_ERASE: - case REQ_OP_WRITE_SAME: + case REQ_OP_WRITE_ZEROES: + return true; + default: + break; + } } - return r; + return false; } static bool __process_abnormal_io(struct clone_info *ci, struct dm_target *ti,
Attachment:
pgpCaSwD7bPBp.pgp
Description: OpenPGP digital signature