Hi all, Today's linux-next merge of the tip tree got a conflict in: arch/powerpc/include/asm/livepatch.h between commit: a4520b252765 ("powerpc/ftrace: Add support for livepatch to PPC32") from the powerpc tree and commit: a557abfd1a16 ("x86/livepatch: Validate __fentry__ location") from the tip tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc arch/powerpc/include/asm/livepatch.h index 6f10de6af6e3,7b9dcd51af32..000000000000 --- a/arch/powerpc/include/asm/livepatch.h +++ b/arch/powerpc/include/asm/livepatch.h @@@ -14,21 -14,11 +14,11 @@@ #ifdef CONFIG_LIVEPATCH static inline void klp_arch_set_pc(struct ftrace_regs *fregs, unsigned long ip) { - struct pt_regs *regs = ftrace_get_regs(fregs); - - regs_set_return_ip(regs, ip); + ftrace_instruction_pointer_set(fregs, ip); } - - #define klp_get_ftrace_location klp_get_ftrace_location - static inline unsigned long klp_get_ftrace_location(unsigned long faddr) - { - /* - * Live patch works on PPC32 and only with -mprofile-kernel on PPC64. In - * both cases, the ftrace location is always within the first 16 bytes. - */ - return ftrace_location_range(faddr, faddr + 16); - } +#endif /* CONFIG_LIVEPATCH */ +#ifdef CONFIG_LIVEPATCH_64 static inline void klp_init_thread_info(struct task_struct *p) { /* + 1 to account for STACK_END_MAGIC */
Attachment:
pgpgGqq90RKwE.pgp
Description: OpenPGP digital signature