Re: [PATCH] acpi: require CRC32 to build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/30/2022 11:58 PM, Guenter Roeck wrote:
On 1/30/22 14:38, Randy Dunlap wrote:
ACPI core now requires crc32() but the kernel build can fail when
CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.

Fixes this build error:

ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'

Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Applied as 5.17-rc material, thanks!


---
  drivers/acpi/Kconfig |    1 +
  1 file changed, 1 insertion(+)

--- linux-next-20220128.orig/drivers/acpi/Kconfig
+++ linux-next-20220128/drivers/acpi/Kconfig
@@ -11,6 +11,7 @@ menuconfig ACPI
      depends on ARCH_SUPPORTS_ACPI
      select PNP
      select NLS
+    select CRC32
      default y if X86
      help
        Advanced Configuration and Power Interface (ACPI) support for





[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux