On 04.01.2022 01:15, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pm tree, today's linux-next build (x86_84 allmodconfig)
> failed like this:
>
> sound/soc/sh/rz-ssi.c: In function 'rz_ssi_probe':
> sound/soc/sh/rz-ssi.c:1023:2: error: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Werror=unused-result]
> 1023 | pm_runtime_resume_and_get(&pdev->dev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 877d952c261e ("PM: runtime: Annotate pm_runtime_resume_and_get() as __must_check")
>
> This also produced the following warnings in my arm multi_v7_defconfig
> build:
>
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_hw_init':
> drivers/crypto/stm32/stm32-hash.c:816:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
> 816 | pm_runtime_resume_and_get(hdev->dev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_import':
> drivers/crypto/stm32/stm32-hash.c:1003:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
> 1003 | pm_runtime_resume_and_get(hdev->dev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_export':
> drivers/crypto/stm32/stm32-hash.c:965:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
> 965 | pm_runtime_resume_and_get(hdev->dev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/crypto/stm32/stm32-cryp.c: In function 'stm32_cryp_hw_init':
> drivers/crypto/stm32/stm32-cryp.c:545:2: warning: ignoring return value of 'pm_runtime_resume_and_get' declared with attribute 'warn_unused_result' [-Wunused-result]
> 545 | pm_runtime_resume_and_get(cryp->dev);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> I have used the pm tree from next-20211224 for today.
>
The patch in the pm tree annotating pm_runtime_resume_and_get() as __must_check
follows some fixes of pm_runtime_resume_and_get() usage that went through other
trees. These fixes are in linux-next but don't seem to be in the pm tree.
We talk about:
f04b4fb47d83 ("ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()")
3d6b661330a7 ("crypto: stm32 - Revert broken pm_runtime_resume_and_get changes")
