On Fri, Oct 08, 2021 at 11:53:11AM +0200, Sergio Paracuellos wrote: > Some MIPS defconfigs that don't define 'CONFIG_PCI_DRIVERS_GENERIC' but > define 'CONFIG_PCI_DRIVERS_LEGACY' or none of them, can fail when they are > built since definition for 'pci_remap_iospace' is being done in include > file 'arch/mips/include/asm/pci.h' and the specific function implemented > in 'arch/mips/pci/pci-generic.c'. MIPS PCI drivers that don't use generic > PCI core APIs don't really need 'pci_remap_iospace' to be defined at all. > Hence, change definition for 'pci_remap_iospace' to be dependent on the > preprocessor 'CONFIG_PCI_DRIVERS_GENERIC' definition to avoid possible > build problems. > > CC: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Fixes: 9f76779f2418 ("MIPS: implement architecture-specific 'pci_remap_iospace()'") > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > --- > Hi Greg, Thomas, Stephen, > > I guess this should also go through the staging-tree. Now queued up, thanks! greg k-h