Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > [-- text/plain, encoding quoted-printable, charset: US-ASCII, 18 lines --] > > Hi all, > > After merging the crypto tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined! > > Caused by commit > > adad556efcdd ("crypto: api - Fix built-in testing dependency failures") > > I have reverted that commit for today. Oops, does this patch fix the problem? ---8<--- We need to export crypto_boot_test_finished in case api.c is built-in while algapi.c is built as a module. Fixes: adad556efcdd ("crypto: api - Fix built-in testing dependency failures") Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> diff --git a/crypto/api.c b/crypto/api.c index 1cf1f03347cc..ee5991fe11f8 100644 --- a/crypto/api.c +++ b/crypto/api.c @@ -32,6 +32,7 @@ BLOCKING_NOTIFIER_HEAD(crypto_chain); EXPORT_SYMBOL_GPL(crypto_chain); DEFINE_STATIC_KEY_FALSE(crypto_boot_test_finished); +EXPORT_SYMBOL_GPL(crypto_boot_test_finished); static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg); -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt