Re: linux-next: Fixes tag needs some work in the i2c tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/18/21 12:49 AM, Stephen Rothwell wrote:

[...]
> In commit
> 
>   fcc750e0f4d8 ("i2c: s3c2410: fix IRQ check")
> 
> Fixes tag
> 
>   Fixes: 2bbd681ba2b ("i2c-s3c2410: Change IRQ to be plain integer.")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> So:
> 
> Fixes: 2bbd681ba2bf ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")

   Sorry for this copypaste blunder. :-/

> Or maybe you meant:
> 
> Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")

   Yes, this one looks more correct.

   Wolfram, what should we do now?
 
MBR, Sergei



[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux