RE: linux-next: Fixes tags need some work in the net tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stephen,

Thanks for reporting this, it's a mistake when adding Fixes tag. And ./scripts/checkpatch.pl script seems can't 
report this issue(even with --strict parameter).

Could you tell me how can you get these errors before sending out the patches for reviewing?
  
Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Sent: 2021年6月17日 6:03
> To: David Miller <davem@xxxxxxxxxxxxx>; Networking
> <netdev@xxxxxxxxxxxxxxx>
> Cc: Fugang Duan <fugang.duan@xxxxxxx>; Joakim Zhang
> <qiangqing.zhang@xxxxxxx>; Linux Kernel Mailing List
> <linux-kernel@xxxxxxxxxxxxxxx>; Linux Next Mailing List
> <linux-next@xxxxxxxxxxxxxxx>
> Subject: linux-next: Fixes tags need some work in the net tree
> 
> Hi all,
> 
> In commit
> 
>   cb3cefe3f3f8 ("net: fec_ptp: add clock rate zero check")
> 
> Fixes tag
> 
>   Fixes: commit 85bd1798b24a ("net: fec: fix spin_lock dead lock")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected
> 
> In commit
> 
>   8f269102baf7 ("net: stmmac: disable clocks in
> stmmac_remove_config_dt()")
> 
> Fixes tag
> 
>   Fixes: commit d2ed0a7755fe ("net: ethernet: stmmac: fix of-node and
> fixed-link-phydev leaks")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected
> 
> --
> Cheers,
> Stephen Rothwell




[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux