Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20210608 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Mon Jun 7 13:23:02 2021 -0700 e532a096be0e ("net: usb: asix: ax88772: add phylib support") Coverity reported the following: *** CID 1505172: Control flow issues (NO_EFFECT) /drivers/net/usb/asix_devices.c: 708 in ax88772_init_phy() 702 static int ax88772_init_phy(struct usbnet *dev) 703 { 704 struct asix_common_private *priv = dev->driver_priv; 705 int ret; 706 707 priv->phy_addr = asix_read_phy_addr(dev, true); vvv CID 1505172: Control flow issues (NO_EFFECT) vvv This less-than-zero comparison of an unsigned value is never true. "priv->phy_addr < 0". 708 if (priv->phy_addr < 0) 709 return priv->phy_addr; 710 711 snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT, 712 priv->mdio->id, priv->phy_addr); 713 If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx> Addresses-Coverity-ID: 1505172 ("Control flow issues") Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") Thanks for your attention! -- Coverity-bot
