On 5/24/21 11:39 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20210524: > on x86_64: # CONFIG_ACPI is not set ../drivers/cpufreq/intel_pstate.c:495:59: warning: ‘struct cppc_perf_caps’ declared inside parameter list will not be visible outside of this definition or declaration static bool intel_pstate_cppc_perf_valid(u32 perf, struct cppc_perf_caps *caps) ^~~~~~~~~~~~~~ ../drivers/cpufreq/intel_pstate.c: In function ‘intel_pstate_cppc_perf_valid’: ../drivers/cpufreq/intel_pstate.c:497:29: error: dereferencing pointer to incomplete type ‘struct cppc_perf_caps’ return perf && perf <= caps->highest_perf && perf >= caps->lowest_perf; ^~ ../drivers/cpufreq/intel_pstate.c: At top level: ../drivers/cpufreq/intel_pstate.c:501:13: warning: ‘struct cppc_perf_caps’ declared inside parameter list will not be visible outside of this definition or declaration struct cppc_perf_caps *caps) ^~~~~~~~~~~~~~ ../drivers/cpufreq/intel_pstate.c: In function ‘intel_pstate_cppc_perf_caps’: ../drivers/cpufreq/intel_pstate.c:503:6: error: implicit declaration of function ‘cppc_get_perf_caps’; did you mean ‘get_ibs_caps’? [-Werror=implicit-function-declaration] if (cppc_get_perf_caps(cpu->cpu, caps)) ^~~~~~~~~~~~~~~~~~ get_ibs_caps ../drivers/cpufreq/intel_pstate.c:506:13: error: dereferencing pointer to incomplete type ‘struct cppc_perf_caps’ return caps->highest_perf && caps->lowest_perf <= caps->highest_perf; ^~ ../drivers/cpufreq/intel_pstate.c: In function ‘intel_pstate_hybrid_hwp_calibrate’: ../drivers/cpufreq/intel_pstate.c:533:24: error: storage size of ‘caps’ isn’t known struct cppc_perf_caps caps; ^~~~ ../drivers/cpufreq/intel_pstate.c:533:24: warning: unused variable ‘caps’ [-Wunused-variable] -- ~Randy Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>