On Tue, May 11, 2021 at 10:51:14AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the cgroup tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: Hi Stephen! I've noticed this error and sent v2 almost immediately after the first version, however it looks like the first version got merged by a mistake. Tejun, can you, please, drop the first version and replace it with v2? There is a trivial s/task/tsk fix. Thank you and sorry for the confusion! Roman > > In file included from include/linux/string.h:6, > In file included from include/linux/string.h:6, > from arch/powerpc/include/asm/paca.h:15, > from arch/powerpc/include/asm/current.h:13, > from include/linux/sched.h:12, > from include/linux/cgroup.h:12, > from kernel/cgroup/cgroup-internal.h:5, > from kernel/cgroup/cgroup.c:31: > kernel/cgroup/cgroup.c: In function 'cgroup_exit': > kernel/cgroup/cgroup.c:6270:17: error: 'task' undeclared (first use in this function); did you mean 'tsk'? > 6270 | if (unlikely(!(task->flags & PF_KTHREAD) && > | ^~~~ > include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' > 78 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > kernel/cgroup/cgroup.c:6270:17: note: each undeclared identifier is reported only once for each function it appears in > 6270 | if (unlikely(!(task->flags & PF_KTHREAD) && > | ^~~~ > include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' > 78 | # define unlikely(x) __builtin_expect(!!(x), 0) > | ^ > > Caused by commit > > c740aad01e41 ("cgroup: inline cgroup_task_freeze()") > > I have used the cgroup tree from next-20210510 for today. > > -- > Cheers, > Stephen Rothwell