On 2/10/21 7:29 PM, Liu, Shuo A wrote:
>
>
> On 2/11/2021 01:52, Randy Dunlap wrote:
>> On 2/10/21 3:42 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210209:
>>>
>>
>> ../drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’:
>> ../drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function ‘remove_cpu’; did you mean ‘register_cpu’? [-Werror=implicit-function-declaration]
>> remove_cpu(cpu);
>>
>> ../drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function ‘add_cpu’; did you mean ‘task_cpu’? [-Werror=implicit-function-declaration]
>> add_cpu(cpu);
>>
>>
>> Full randconfig file is attached.
>>
>
> Thanks.
> The vCPU removing depends on CONFIG_HOTPLUG_CPU. Below change could fix.
Yes, it does, thanks.
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
> ---
>
> diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c
> index 1f6b7c54a1a4..e340788aacdf 100644
> --- a/drivers/virt/acrn/hsm.c
> +++ b/drivers/virt/acrn/hsm.c
> @@ -372,6 +372,7 @@ static int acrn_dev_release(struct inode *inode,
> struct file *filp)
> return 0;
> }
>
> +#ifdef CONFIG_HOTPLUG_CPU
> static ssize_t remove_cpu_store(struct device *dev,
> struct device_attribute *attr,
> const char *buf, size_t count)
> @@ -403,9 +404,12 @@ static ssize_t remove_cpu_store(struct device *dev,
> return ret;
> }
> static DEVICE_ATTR_WO(remove_cpu);
> +#endif
>
> static struct attribute *acrn_attrs[] = {
> +#ifdef CONFIG_HOTPLUG_CPU
> &dev_attr_remove_cpu.attr,
> +#endif
> NULL
> };
>
--
~Randy
