Hi Jacopo, Thanks for your patch! On Mon, Feb 8, 2021 at 7:22 PM Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote: > With the introduction of the RDACM21 camera module support in > commit a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module") > the symbols defined by the max9271 library were exported twice > if multiple users of the library were compiled in at the same time. > > In example: > WARNING: modpost: drivers/media/i2c/rdacm21-camera_module: > 'max9271_set_serial_link' exported twice. Previous export was in > drivers/media/i2c/rdacm20-camera_module.ko > > Fix this by making the rdacm21 file a module and have the driver max9271 > using its functions select it. > > Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module") > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Suggested-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds