On Wed, Nov 18, 2020 at 4:30 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > drivers/gpio/gpio-xilinx.c: In function 'xgpio_remove': > drivers/gpio/gpio-xilinx.c:275:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration] > 275 | pm_runtime_disable(&pdev->dev); > | ^~~~~~~~~~~~~~~~~~ > > Caused by commit > > fbbeb6c0a1d0 ("gpio: gpio-xilinx: Add remove function") Ooops my fault for merging patches out-of-order, I'll go in and fix it up manually by removing the pm call from remove(). Yours, Linus Walleij