On Mon, Nov 02, 2020 at 10:27:11AM +0000, Christoph Hellwig wrote: > On Mon, Nov 02, 2020 at 10:28:34AM +0100, Daniel Vetter wrote: > > > --- a/include/linux/swiotlb.h > > > +++ b/include/linux/swiotlb.h > > > @@ -5,6 +5,9 @@ > > > #include <linux/dma-direction.h> > > > #include <linux/init.h> > > > #include <linux/types.h> > > > +#ifndef CONFIG_SWIOTLB > > > +#include <linux/limits.h> > > > +#endif > > No conditional includes please. And the proper fix for the reported > issue is to stop poking into swiotlb internals in random drivers.. Meaning?