Re: [PATCH v2 2/2] selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2 Oct 2020 01:40:49 -0700 John Hubbard <jhubbard@xxxxxxxxxx> wrote:

> commit cb2ab76685d7 ("selftests/vm: rename run_vmtests -->
> run_vmtests.sh") changed the name of run_vmtests to run_vmtest.sh, but
> inadvertently dropped the executable bits.

We cannot depend on the x bit.  Because downloading linux-foo.patch.gz
and installing it with patch(1) is a supported way of obtaining Linux. 
And patch(1) loses the x bit.

If $(CONFIG_SHELL) is unavailable then invoking the script with
"/bin/sh foo.sh" should do the trick.

> Somehow the name is missing an "s", too. Fix both of these problems by
> renaming, and restoring the executable bits.

But that's what your patch did!

tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} | 0

Here: https://lkml.kernel.org/r/20200929212747.251804-4-jhubbard@xxxxxxxxxx


So all confused.  I'll drop this version - please redo and resend when
convenient?



[Index of Archives]     [Linux Kernel]     [Linux USB Development]     [Yosemite News]     [Linux SCSI]

  Powered by Linux