On 10/1/20 11:32 PM, Lee Jones wrote: > On Thu, 01 Oct 2020, Randy Dunlap wrote: > >> On 10/1/20 4:39 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20200930: >>> >> >> on x86_64: >> >> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': >> simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c' >> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init': >> simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver' >> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit': >> simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver' >> >> >> CONFIG_I2C=m >> CONFIG_MFD_SIMPLE_MFD_I2C=y >> CONFIG_MFD_SL28CPLD=y >> >> >> Is linux-next missing the source code for CONFIG_MFD_SL28CPLD? > > There isn't any associated source code. It's a virtual symbol. > >> The build error is caused by: >> >> config MFD_SL28CPLD >> tristate "Kontron sl28cpld Board Management Controller" >> select MFD_SIMPLE_MFD_I2C >> >> that "select" when "depends on I2C" is absent/missing. > > Okay, so CONFIG_MFD_SIMPLE_MFD_I2C needs to depend on I2C too? I made > the assumption that 'select REGMAP_I2C' would do the right thing. "select" never follows any dependency chains, so Yes, the other symbol needs to depend on I2C also. thanks. -- ~Randy