On Wed, Sep 30, 2020 at 09:47:49PM +0530, Naresh Kamboju wrote: > On Tue, 29 Sep 2020 at 01:56, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > v2: > > - update documentation > > - include SPDX line in extracted script > > v1: https://lore.kernel.org/linux-kselftest/20200925234527.1885234-1-keescook@xxxxxxxxxxxx/ > > > > > > Hi! > > > > I really like Hangbin Liu's intent[1] but I think we need to be a little > > more clean about the implementation. This extracts run_kselftest.sh from > > the Makefile so it can actually be changed without embeds, etc. Instead, > > generate the test list into a text file. Everything gets much simpler. > > :) > > > > And in patch 2, I add back Hangbin Liu's new options (with some extra > > added) with knowledge of "collections" (i.e. Makefile TARGETS) and > > subtests. This should work really well with LAVA too, which needs to > > manipulate the lists of tests being run. > > > > Thoughts? > > I have tested this patch set on LAVA with full run and it went well. Thank you! You can include this as a tag too, so a "b4 am" will pick it up: Tested-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> -Kees > > > > > -Kees > > > > [1] https://lore.kernel.org/lkml/20200914022227.437143-1-liuhangbin@xxxxxxxxx/ > > > > Kees Cook (3): > > selftests: Extract run_kselftest.sh and generate stand-alone test list > > selftests/run_kselftest.sh: Make each test individually selectable > > doc: dev-tools: kselftest.rst: Update examples and paths > > > > Documentation/dev-tools/kselftest.rst | 35 +++++---- > > tools/testing/selftests/Makefile | 26 ++----- > > tools/testing/selftests/lib.mk | 5 +- > > tools/testing/selftests/run_kselftest.sh | 93 ++++++++++++++++++++++++ > > 4 files changed, 124 insertions(+), 35 deletions(-) > > create mode 100755 tools/testing/selftests/run_kselftest.sh > > > > -- > > 2.25.1 > > > > - Naresh -- Kees Cook
