On Tue, Sep 29, 2020 at 02:41:27PM +0800, miaoqinglang wrote: > > > 在 2020/9/29 14:01, Stephen Rothwell 写道: > > Hi all, > > > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe': > > drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' [-Wunused-variable] > > 806 | int ret, id, irq; > > | ^~~ > > > > Introduced by commit > > > > b63537020db3 ("serial: mvebu-uart: simplify the return expression of mvebu_uart_probe()") > > > Hi Greg, > > Sorry about the noise for remaining the unused variable 'ret' in commit > b63537020db3. > > Should I send another patch to clean up this warning or send another v2 > patch instead? A fix-up patch would be best, as this is already in my tree. thanks, greg k-h