On 9/28/20 4:55 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20200925: > on i386: ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove': hisi_hikey_usb.c:(.text+0x14): undefined reference to `usb_role_switch_unregister' ld: hisi_hikey_usb.c:(.text+0x20): undefined reference to `usb_role_switch_put' ld: drivers/misc/hisi_hikey_usb.o: in function `hub_usb_role_switch_set': hisi_hikey_usb.c:(.text+0x37): undefined reference to `usb_role_switch_get_drvdata' ld: drivers/misc/hisi_hikey_usb.o: in function `relay_set_role_switch': hisi_hikey_usb.c:(.text+0x1b2): undefined reference to `usb_role_switch_set_role' ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_probe': hisi_hikey_usb.c:(.text+0x2ca): undefined reference to `usb_role_switch_get' ld: hisi_hikey_usb.c:(.text+0x369): undefined reference to `usb_role_switch_register' ld: hisi_hikey_usb.c:(.text+0x380): undefined reference to `usb_role_switch_put' It looks like HISI_HIKEY_USB should at least depend on USB and probably on USB_ROLE_SWITCH. -- ~Randy Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
