On Tue, Sep 15, 2020 at 03:16:42PM +0200, Bartosz Golaszewski wrote: > On Tue, Sep 15, 2020 at 3:12 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > On Tue, Sep 15, 2020 at 02:01:56PM +0200, Anders Roxell wrote: > > > On Tue, 8 Sep 2020 at 18:40, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > > > > > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > > > > > I initially sent this as part of the gpio-mockup overhaul but since > > > > these patches are indepentent and the work on gpio-mockup may become > > > > more complicated - I'm sending these separately. > > > > > > > > The only change is adding additional property helpers to count strings > > > > in array. > > > > > > > > Bartosz Golaszewski (3): > > > > device: property: add helpers to count items in string arrays > > > > gpiolib: generalize devprop_gpiochip_set_names() for device properties > > > > gpiolib: unexport devprop_gpiochip_set_names() > > > > Ha-ha, OF unittest is of_node centric. definitely there is no backed device. > > > > Bart, it seems we are stuck with fwnode interface. > > > > Wait what?! This means the implementation is wrong - the whole concept > of device properties is to be generic and to hide the underlying > fwnode or OF properties. If anything we should fix > device/base/property.c to fall back to OF. > > What is happening exactly? If all fwnode code compiled out? > > I'll try to give it a spin and see what can be done but I don't like > that device_property_* functions fail if you have OF but not fwnode. Read my next reply. It seems only OF unittest issue % git grep -n -w fwnode -- drivers/of/unittest* | wc -l 0 % git grep -n -w fwnode -- drivers/of/ | wc -l 50 -- With Best Regards, Andy Shevchenko