Hi Stephen, On 14-09-20, 14:29, Stephen Rothwell wrote: > Hi all, > > After merging the dmaengine tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet': > drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable] > 287 | struct sf_pdma_desc *desc = chan->desc; > | ^~~~ > > Introduced by commit > > 8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice") Thanks for the report. The function directly uses chan->desc, so yes this can be removed, Sending patch shortly Thanks -- ~Vinod